Skip to content

Time out waiting on SSH connection gracefully, use asyncio on receiving end. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 3, 2024
Merged

Time out waiting on SSH connection gracefully, use asyncio on receiving end. #3

merged 5 commits into from
Oct 3, 2024

Conversation

@belitskiy
Copy link
Contributor

@belitskiy belitskiy commented Sep 30, 2024

No description provided.

@MichaelHudgins
Copy link
Collaborator

MichaelHudgins commented Oct 2, 2024

Which PR are you using to run jobs to test this?

@belitskiy
Copy link
Contributor Author

belitskiy commented Oct 2, 2024 •
edited
Loading

Which PR are you using to run jobs to test this?
google-ml-infra/jax-fork#26
(Didn't bother to remove jax-fork changes to the code from that PR, I only added the checking out and using of this repo's code)

@MichaelHudgins
Copy link
Collaborator

MichaelHudgins commented Oct 2, 2024 •
edited
Loading

Could you add a workflow to this repo that listens for the labels for testing purposes? This repo has the same runners available to it.

@belitskiy
Copy link
Contributor Author

belitskiy commented Oct 2, 2024

Could you add a workflow to this repo that listens for the labels for testing purposes? This repo has the same runners available to it.

#7

@MichaelHudgins
Copy link
Collaborator

MichaelHudgins commented Oct 2, 2024

Could you add a workflow to this repo that listens for the labels for testing purposes? This repo has the same runners available to it.

#7

Approved it, i'll give this one a try with that merged

@belitskiy belitskiy merged commit 8f3f5b3 into main Oct 3, 2024
5 checks passed
@belitskiy belitskiy deleted the ssh_graceful_timeout branch October 29, 2024 16:11
belitskiy added a commit that referenced this pull request Apr 23, 2025
@belitskiy
Test out the fallback #3.
7ea1378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelHudgins MichaelHudgins MichaelHudgins approved these changes

Assignees

@MichaelHudgins MichaelHudgins

@belitskiy belitskiy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@belitskiy @MichaelHudgins