Add buildifier composite action and a test workflow #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the buildifier action to check for .bzl files as well.
MichaelHudgins
requested changes
May 29, 2025
| defaults: | ||
| run: | ||
| shell: bash | ||
| jobs: |
There was a problem hiding this comment.
Huh, i though zizmor should have flagged this but missing a permisions:{} block
Comment on lines
+21
to
+23
| if: | | ||
| github.event.sender.type == 'User' || | ||
| contains(github.event.pull_request.body, 'RUN_BUILDIFIER') |
There was a problem hiding this comment.
Like the other one i think we should just run it, the only bot we have is one we would want to have PRs run against anyway. For example if dependabot updates the sha of checkouts below, or of the aciton.yaml.
I am more strongly suspecting XLA did this to prevent running on copybara created PRs.
Comment on lines
+21
to
+23
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| fetch-depth: 0 # Fetch full history for accurate diffing |
There was a problem hiding this comment.
Same convo as the other one but we can have that conversation over there
| # Compare PR head against the base branch to find changed files. | ||
| GIT_DIFF_CMD="git diff -z --name-only --diff-filter=d origin/$TARGET_BRANCH HEAD -- $FILE_PATTERNS" | ||
|
|
||
| $GIT_DIFF_CMD | xargs -0 buildifier --mode=check -v |
There was a problem hiding this comment.
Same as other, we need to decide what we do if its a push event.
Do you know how long buildifier takes to run on the entire JAX repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.