Skip to content

Conversation

@ybaturina
Copy link
Collaborator

@ybaturina ybaturina commented Jan 12, 2026

  1. Move common tools to //common.
  2. Move all GPU-related repo rules to //gpu
  3. Move extensions for bzlmode to //extensions.
  4. Remove unused Mac and Windows toolchains from CUDA config.

@ybaturina ybaturina requested a review from vam-google January 12, 2026 23:03
@ybaturina ybaturina requested a review from yuriivcs January 14, 2026 16:44
@yuriivcs
Copy link
Collaborator

Suggestions (not mandatory to do anything from below list):
Would it be possible to rename //gpu/cuda/crosstool to //gpu/cuda/legacy (or move it there)? This would help developers who work with rules_ml_toolchain understand that this code is already deprecated (some developers still think that this is mainstream toolchains).
Additionally, I think we could simplify gpu/cuda/local_config_cuda.BUILD by updating the deprecated settings in our ML projects to point to the configuration in //common and then remove most of configuration from this file.

Copy link
Collaborator

@yuriivcs yuriivcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybaturina ybaturina merged commit d8cb9c2 into google-ml-infra:main Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants