Add a GRPC Client to invoke the GRPC server to the K8s package #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quoctruong
force-pushed
the
quoct/add_grpc_client
branch
from
9252413 to
3f8380d
Compare
quoctruong
changed the title
MichaelHudgins
approved these changes
Jun 5, 2025
Comment on lines
+112
to
+114
| if (status?.phase === 'Succeeded') { | ||
| throw new Error(`Failed to get pod ${podName} status`) | ||
| } |
There was a problem hiding this comment.
Without looking too far into the backing code, do we need some backoff / retry here if the pod is still launching or should it already be in a good state given checks that would have already run?
There was a problem hiding this comment.
So when this step (run-script-step) is called, the pod is already ready. That was in a separate step done prior to this.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the logic is in
packages/k8s/src/hooks/run-script-step.tsfile.This does not include the ability to not run a script if it has the id yet. It also does not include the code to set up the container with the server.
I will also add some tests in a separate PR.
Also update typescript to 5.0.3 to resolve some issues when running tests.