Add containerized services to prepare-job #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinxinmo
reviewed
Sep 26, 2025
packages/k8s/tests/k8s-utils-test.ts
Outdated
| } | ||
| ] | ||
| generateServicesName(services) | ||
| expect.arrayContaining([ |
There was a problem hiding this comment.
Are these artifacts?
expect.arrayContaining([
expect.objectContaining({
name: 'commonName',
value: CertCommonName.ROOT
})
])
xinxinmo
approved these changes
Sep 26, 2025
quoctruong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already supported in the runner-container-hook that we forked. However, we need to make sure the services container are not using the script executor entrypoint.
Additionally, the current logic has a bug where it does not work if there are multiple service containers of the same image.
Or if the service container image name has a -