Remove TPU's requests and limits from the main container if a service container is requesting for it #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by a service container
xinxinmo
reviewed
Oct 1, 2025
| container.resources.limits['google.com/tpu'] | ||
| ) { | ||
| delete container.resources.limits['google.com/tpu'] | ||
| } |
There was a problem hiding this comment.
nit: Let's also add a log for indicating the delete operation was finished successfully for debugging?
There was a problem hiding this comment.
Oh I don't see it's added yet. Maybe the latest commit hasn't been uploaded?
xinxinmo
approved these changes
Oct 1, 2025
| container.resources.limits['google.com/tpu'] | ||
| ) { | ||
| delete container.resources.limits['google.com/tpu'] | ||
| } |
There was a problem hiding this comment.
Oh I don't see it's added yet. Maybe the latest commit hasn't been uploaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor the code into a separate function and add logic to check that only 1 service container is requesting for TPU's.