Skip to content

Fix a bug where we are not removing TPU requests from the main container correctly #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

Fix a bug where we are not removing TPU requests from the main container correctly #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ea0f2
Fix bug with TPU request
quoctruong Oct 16, 2025
2324c21
Fix formatting
quoctruong Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/k8s/src/hooks/prepare-job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,13 @@ export function processServiceContainers(
)
})

const tpuRequestingContainers = services.filter(
const tpuRequestingContainers = serviceContainers.filter(
service =>
service.resources?.limits && service.resources.limits['google.com/tpu']
)
core.debug(
`There are ${tpuRequestingContainers.length} service container requesting for TPU's.`
)

if (tpuRequestingContainers.length > 1) {
throw new Error(
Expand Down
Loading