Eliminate possible future bug: keep basins order (no set)#244
Merged
amitmarkel merged 1 commit intomainfrom Feb 18, 2026
Merged
Eliminate possible future bug: keep basins order (no set)#244amitmarkel merged 1 commit intomainfrom
set)#244amitmarkel merged 1 commit intomainfrom
Conversation
Collaborator
amitmarkel
commented
Feb 18, 2026
amitmarkel
commented
- slightly improve runtime+memory improvement: basins without excluded ones is computed once
- safer self.basins (readonly tuple)
It's also a slight runtime+memory improvement: basins without excluded ones is computed once.
amitmarkel
changed the title
set)
omrishefi
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.