Skip to content

Add SGD optimizer. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitmarkel merged 1 commit into from
Oct 27, 2025
Merged

Add SGD optimizer. #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/usage/config.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ Training settings
-----------------

- ``optimizer``: Specify which optimizer to use. Currently supported
are Adam and AdamW. New optimizers can be added
are Adam and AdamW and SGD. New optimizers can be added
:py:func:`here <googlehydrology.training.get_optimizer>`.

- ``loss``: Which loss to use. Currently supported are ``MSE``,
Expand Down
2 changes: 2 additions & 0 deletions googlehydrology/training/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ def get_optimizer(model: torch.nn.Module, cfg: Config, *, is_gpu: bool = False)
optimizer = torch.optim.Adam(model.parameters(), lr=cfg.initial_learning_rate, fused=is_gpu)
elif cfg.optimizer.lower() == "adamw":
optimizer = torch.optim.AdamW(model.parameters(), lr=cfg.initial_learning_rate, fused=is_gpu)
elif cfg.optimizer.lower() == "sgd":
optimizer = torch.optim.SGD(model.parameters(), lr=cfg.initial_learning_rate, fused=is_gpu)
else:
raise NotImplementedError(f"{cfg.optimizer} not implemented or not linked in `get_optimizer()`")

Expand Down