feat(sample): A2A+MCP Sample - Replaced by https://github.com/google/A2A/compare/a2a_mcp_sdk_py #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holtskinner
reviewed
May 15, 2025
| content: TaskList = Field(description="List of tasks when the plan is generated") | ||
|
|
||
|
|
||
| class LangraphPlannerAgent(BaseAgent): |
There was a problem hiding this comment.
Change the name of this class to be LangGraphPlannerAgent
holtskinner
requested changes
May 15, 2025
|
|
||
| async def invoke(self, query, session_id) -> dict: | ||
| logger.info(f"Running TaskExecutorAgent for session {session_id}") | ||
| raise NotImplementedError("Please use the streraming function") |
There was a problem hiding this comment.
Suggested change
| raise NotImplementedError("Please use the streraming function") | |
| raise NotImplementedError("Please use the streaming function") |
holtskinner
requested changes
May 16, 2025
Comment on lines
+83
to
+98
| def format_response(self, chunk): | ||
| patterns = [ | ||
| r"```\n(.*?)\n```", | ||
| r"```json\s*(.*?)\s*```", | ||
| r"```tool_outputs\s*(.*?)\s*```", | ||
| ] | ||
|
|
||
| for pattern in patterns: | ||
| match = re.search(pattern, chunk, re.DOTALL) | ||
| if match: | ||
| content = match.group(1) | ||
| try: | ||
| return json.loads(content) | ||
| except json.JSONDecodeError: | ||
| return content | ||
| return chunk |
There was a problem hiding this comment.
This shouldn't be needed if you use Gemini Controlled Generation. Is that possible? https://ai.google.dev/gemini-api/docs/structured-output
There was a problem hiding this comment.
ADK does not like structured output with tools. I tried influencing gemini via config, but ADK does not like that too. So prompt and clean up of the tool use format is what I am left with.
| init_api_key() | ||
| config_logger(logger=logger) | ||
|
|
||
| logger.info("Initializing LanggraphPlannerAgent") |
There was a problem hiding this comment.
Suggested change
| logger.info("Initializing LanggraphPlannerAgent") | |
| logger.info("Initializing LangGraphPlannerAgent") |
Change this name throughout
| self.model, | ||
| checkpointer=memory, | ||
| prompt=prompts.TRAVEL_AGENT_INSTRUCTIONS, | ||
| # prompt=prompts.TRIP_PLANNER_INSTRUCTIONS_1, |
There was a problem hiding this comment.
Remove commented out code
rajeshvelicheti
changed the title
rajeshvelicheti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.nox -s formatfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕