docs: fix frontend build sequence and add Windows compatibility note#1169
Open
TanXudong-Vivo wants to merge 4 commits intogoogle:mainfrom
Open
docs: fix frontend build sequence and add Windows compatibility note#1169TanXudong-Vivo wants to merge 4 commits intogoogle:mainfrom
TanXudong-Vivo wants to merge 4 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to reorder and number the build steps for the samples, ensuring the Web Core library is built first. It also adds a troubleshooting note for Windows users regarding the @rollup/rollup-win32-x64-msvc module. I have no feedback to provide.
8b07c6f to
c8b5f68
Compare
jacobsimionato
approved these changes
Apr 14, 2026
9a1ede8 to
d047847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a logical error in the "Running the Restaurant Finder demo" section of the README.
What changed
renderers/web_coreis built beforerenderers/markdown/markdown-it@rollup/rollup-win32-x64-msvcif neededWhy
@a2ui/markdown-itdepends on@a2ui/web_core. In the current README order, buildingmarkdown-itfirst can result in:TS2307: Cannot find module '@a2ui/web_core'Additionally, on Windows environments,
npm installmay fail to install Rollup's optional native dependency, which can cause thenpm run devstep to fail unless@rollup/rollup-win32-x64-msvcis installed manually.Verification
Verified on a clean Windows environment:
markdown-itfirst failed with TypeScript errorsweb_core -> markdown-it -> lit -> shell) completed successfullyhttp://localhost:5173/Closes #1168
Pre-launch Checklist