fix(docs): fix broken custom_functions link in v0.10 README#1259
Open
ppazosp wants to merge 1 commit intogoogle:mainfrom
Open
fix(docs): fix broken custom_functions link in v0.10 README#1259ppazosp wants to merge 1 commit intogoogle:mainfrom
ppazosp wants to merge 1 commit intogoogle:mainfrom
Conversation
6 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation link for Custom Functions in the README.md file. The review feedback indicates that the pre-review checklist in the PR description is incomplete, which violates the repository's style guide requiring all checklist items to be completed.
|
|
||
| - [Protocol](docs/a2ui_protocol.md) | ||
| - [Custom Functions](docs/custom_functions.md) | ||
| - [Custom Functions](docs/a2ui_custom_functions.md) |
Contributor
There was a problem hiding this comment.
The Pre-Review Checklist in the PR description is incomplete, as the CHANGELOG and tests items are unchecked. This is a violation of the Repository Style Guide (lines 18-20), which requires all checklist steps to be completed.
References
- The Repository Style Guide requires that the Pre-Review Checklist in the PR description be fully completed. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v0.10 README links to
docs/custom_functions.mdwhich doesn't exist. The actual file isdocs/a2ui_custom_functions.md.Pre-launch Checklist