Skip to content

Migrate the rest of python unit tests to conformance tests#1266

Open
nan-yu wants to merge 17 commits intogoogle:mainfrom
nan-yu:conformance-test
Open

Migrate the rest of python unit tests to conformance tests#1266
nan-yu wants to merge 17 commits intogoogle:mainfrom
nan-yu:conformance-test

Conversation

@nan-yu
Copy link
Copy Markdown
Collaborator

@nan-yu nan-yu commented Apr 23, 2026

Description

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the initial implementation of the A2UI C++ SDK, covering schema management, validation, and a streaming parser. It also expands the shared conformance test suite and updates the Python SDK tests to leverage these new cases. Feedback on the C++ implementation suggests ensuring consistent error handling in catalog selection to match conformance expectations, adopting modern memory management with std::unique_ptr in tests, and using custom delimiters for embedded raw strings to prevent parsing errors. Additionally, improvements were recommended for optimizing component lookup complexity and removing an unused dependency in the CMake configuration.

Comment thread agent_sdks/cpp/src/schema/manager.cc Outdated
Comment thread agent_sdks/cpp/tests/test_conformance.cc Outdated
Comment thread agent_sdks/cpp/scripts/generate_embedded_schemas.py Outdated
Comment thread agent_sdks/cpp/src/parser/streaming_impl.cc Outdated
Comment thread agent_sdks/cpp/CMakeLists.txt Outdated
nan-yu added 17 commits April 24, 2026 22:27
@nan-yu nan-yu force-pushed the conformance-test branch from e746d45 to 06efb7e Compare April 24, 2026 22:27
@nan-yu
Copy link
Copy Markdown
Collaborator Author

nan-yu commented Apr 24, 2026

@jiahaog I cannot add you as a reviewer, but feel free to take a look.

I may need to rebase if #1129 is submitted first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant