Migrate the rest of python unit tests to conformance tests#1266
Open
nan-yu wants to merge 17 commits intogoogle:mainfrom
Open
Migrate the rest of python unit tests to conformance tests#1266nan-yu wants to merge 17 commits intogoogle:mainfrom
nan-yu wants to merge 17 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the initial implementation of the A2UI C++ SDK, covering schema management, validation, and a streaming parser. It also expands the shared conformance test suite and updates the Python SDK tests to leverage these new cases. Feedback on the C++ implementation suggests ensuring consistent error handling in catalog selection to match conformance expectations, adopting modern memory management with std::unique_ptr in tests, and using custom delimiters for embedded raw strings to prevent parsing errors. Additionally, improvements were recommended for optimizing component lookup complexity and removing an unused dependency in the CMake configuration.
932a458 to
259a3d8
Compare
6 tasks
259a3d8 to
4b66dc0
Compare
…rdized conformance test data files
…on file and remove legacy parser tests.
…idate utility tests
… schema manager test file
…ate test loader paths
…nt in conformance tests
… data directories
… move validation to anyOf variants
e746d45 to
06efb7e
Compare
Collaborator
Author
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.