Add Support for User Verification (UV) and BioEnrollment #718
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
|
||
| /// Stored counter UV retries. | ||
| UV_RETRIES = 2048; | ||
|
|
||
| /// Stored friendly names for enrolled fingerprints. | ||
| FRIENDLY_NAMES = 2100..2105; |
There was a problem hiding this comment.
Those should be between 2005 and 2037, or between 21 and 999, as per the comment line 60 reserving keys 2048 and above for migration purposes.
Note that cargo test --features=std keys_are_disjoint fails otherwise.
| @@ -386,6 +408,23 @@ pub trait Persist { | |||
| } | |||
| } | |||
|
|
|||
| /// Store a Bio Enrollment friendly name for a given template_id. | |||
| fn store_friendly_name(&mut self, template_id: u8, friendly_name: &str) -> CtapResult<()> { | |||
| let key = keys::FRIENDLY_NAMES.start + template_id as usize; | |||
There was a problem hiding this comment.
We should check key < keys::FRIENDLY_NAMES.end.
|
|
||
| /// Retrieve the Bio Enrollment friendly name for a given template_id. | ||
| fn get_friendly_name(&mut self, template_id: u8) -> CtapResult<String> { | ||
| let key = keys::FRIENDLY_NAMES.start + template_id as usize; |
|
|
||
| match self.find(key)? { | ||
| None => Err(Ctap2StatusCode::CTAP1_ERR_OTHER), | ||
| Some(value) => Ok(String::from_utf8(value).unwrap_or(String::from(""))), |
There was a problem hiding this comment.
We should return an internal error if the value is not UTF-8.
This PR includes our changes to OpenSK to support UV and bioenrollment. Because there is no fingerprint sensor on the nRF52840dk or in Tock, the environment implementation is just a stub.
We are happy to test this PR against our internal hardware platform as updates are made to this PR after feedback.
run_desktop_tests.sh)