Skip to content

Commit

Permalink
Remove workaround hiding potential issues from msan
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 728280419
  • Loading branch information
dsharletg authored and xnnpack-bot committed Feb 18, 2025
1 parent 59daa3e commit 9bcd091
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions test/f32-vscaleexpminusmax.cc
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ class VScaleExpMinusMaxMicrokernelTester {
xnnpack::Buffer<float> x(elements() + XNN_EXTRA_BYTES / sizeof(float));
xnnpack::Buffer<float> y(elements());
xnnpack::Buffer<double> y_ref(elements());
// TODO(b/372792254): This is hiding a possible msan bug in the microkernels tested here.
std::fill(y.begin(), y.end(), 0.0f);
for (size_t iteration = 0; iteration < iterations(); iteration++) {
std::generate(x.begin(), x.end(), std::ref(f32rng));

Expand Down
2 changes: 0 additions & 2 deletions test/f32-vscaleextexp.cc
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ class VScaleExtExpMicrokernelTester {
xnnpack::Buffer<float> x(elements() + XNN_EXTRA_BYTES / sizeof(float));
xnnpack::Buffer<float> y(elements());
xnnpack::Buffer<double> y_ref(elements());
// TODO(b/372792254): This is hiding a possible msan bug in the microkernels tested here.
std::fill(y.begin(), y.end(), 0.0f);
for (size_t iteration = 0; iteration < iterations(); iteration++) {
std::generate(x.begin(), x.end(), std::ref(f32rng));

Expand Down

0 comments on commit 9bcd091

Please sign in to comment.