[gn] Test building AVX512#10250
Merged
Merged
Conversation
dce2fa2 to
5dba839
Compare
34aedd4 to
3a0b008
Compare
Because we don't test it in Github Actions, AVX512 support has bit-rotted in GN a bit. Should take care of a cluster of failures in the latest Chrome integration attempt. [1] Also simplify/unify things for 32-bit. [1] https://chromium-review.googlesource.com/c/chromium/src/+/7615883?tab=checks PiperOrigin-RevId: 916227360
3a0b008 to
1c292bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[gn] Test building AVX512
Because we don't test it in Github Actions, AVX512 support
has bit-rotted in GN a bit. Should take care of a cluster of
failures in the latest Chrome integration attempt. [1]
Also simplify/unify things for 32-bit.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/7615883?tab=checks