[gn] Add support for building/testing AArch32#10259
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+339
to
+398
| runs-on: 'ubuntu-24.04-8core' | ||
| timeout-minutes: 15 | ||
| env: | ||
| CCACHE_SLOPPINESS: time_macros,modules | ||
| CCACHE_DIR: /home/runner/.cache/ccache | ||
| CCACHE_DEPEND: 1 | ||
| CCACHE_MAX_SIZE: 5G | ||
| CCACHE_COMPILERCHECK: content | ||
| steps: | ||
| - name: Restore ccache | ||
| id: cache-ccache-restore | ||
| uses: actions/cache@v5 | ||
| with: | ||
| path: | | ||
| /home/runner/.cache/ccache | ||
| key: ccache-linux-arm-${{ github.ref_name }}-${{ github.sha }} | ||
| restore-keys: | | ||
| ccache-linux-arm-${{ github.ref_name }}- | ||
| ccache-linux-arm-master- | ||
| - name: Install ccache | ||
| run: | | ||
| sudo apt-get install -y ccache qemu-user qemu-user-static qemu-user-binfmt | ||
| - name: Install Depot Tools | ||
| uses: newkdev/setup-depot-tools@v1.0.1 | ||
| - name: Write .gclient | ||
| run: | | ||
| cat <<EOF > .gclient | ||
| solutions = [ | ||
| { "name" : 'xnnpack', | ||
| "url" : 'https://github.com/google/XNNPACK', | ||
| "deps_file" : 'DEPS', | ||
| "managed" : False, | ||
| "custom_deps" : { | ||
| }, | ||
| "custom_vars": {}, | ||
| }, | ||
| ] | ||
| EOF | ||
| - name: Sync to commit and run hooks | ||
| run: gclient sync --reset --force --upstream --revision $GITHUB_SHA | ||
| - name: Check GN formatting | ||
| run: | | ||
| git cl format --presubmit --no-clang-format --no-python --diff | ||
| working-directory: ${{ github.workspace }}/xnnpack | ||
| - name: Generate build files | ||
| run: | | ||
| gn gen --check --args="is_debug=false clang_use_chrome_plugins=false dcheck_always_on=true cc_wrapper=\"ccache\" symbol_level=0 target_cpu=\"arm\" use_siso=true" out/arm.dchecks | ||
| working-directory: ${{ github.workspace }}/xnnpack | ||
| - name: Build all targets (Release + debug checks) | ||
| run: | | ||
| autoninja -C out/arm.dchecks | ||
| working-directory: ${{ github.workspace }}/xnnpack | ||
| - name: Print ccache stats | ||
| run: ccache -s | ||
| - name: Install sysroot | ||
| run: ./build/linux/sysroot_scripts/install-sysroot.py --arch=armhf | ||
| working-directory: ${{ github.workspace }}/xnnpack | ||
| - name: Run tests | ||
| run: | | ||
| python3 scripts/run-gn-tests.py out/arm.dchecks --sysroot=build/linux/debian_bullseye_armhf-sysroot --architecture=arm |
copybara-service
Bot
force-pushed
the
test_916180875
branch
5 times, most recently
from
b23d42e to
b1efb7d
Compare
Although AArch32 is not really the current focus for Chrome performance, as we've got the kernels around, there's no harm in having it. Also modifies the GN test script to support testing on x64 hosts. PiperOrigin-RevId: 916281274
copybara-service
Bot
force-pushed
the
test_916180875
branch
from
b1efb7d to
1052f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[gn] Add support for building/testing AArch32
Although AArch32 is legacy at this point and not really the
focus for Chrome performance, as we've got the
kernels around there's probably no harm in having it.