Prepare for LoongArch SX and ASX #7640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option named XNNPACK_ENABLE_CPUINFO so that avoid compiling cpuinfo for LoongArch (and Hexagon). Add "&& XNN_ARCH_RISCV" in transpose-config for RISCV. Others are prepared for LoongArch SX and ASX.
fbarchard
approved these changes
Jan 6, 2025
|
Gentle ping 😄. Is there anything I need to do? @fbarchard |
fbarchard
reviewed
Jan 28, 2025
| @@ -197,7 +197,7 @@ static void init_transpose_config(void) { | |||
| .const_size_ukernel = (xnn_transposec_ukernel_fn) xnn_x24_transposec_ukernel__1x2_scalar, | |||
| .tile_size = 32, | |||
| }; | |||
| #if XNN_ENABLE_RISCV_VECTOR | |||
| #if XNN_ENABLE_RISCV_VECTOR && XNN_ARCH_RISCV | |||
There was a problem hiding this comment.
this change seems unrelated and unnecessary, since RISCV_VECTOR is only on RISCV?
There was a problem hiding this comment.
Because the XNNPACK_ENABLE_RISCV_VECTOR set default ON in CMakeLists.txt which csuse XNN_ENABLE_RISCV_VECTOR is true if we don't set it.
https://github.com/google/XNNPACK/blob/master/CMakeLists.txt#L138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Add an option named XNNPACK_ENABLE_CPUINFO so that avoid compiling cpuinfo for LoongArch (and Hexagon).
2, Add "&& XNN_ARCH_RISCV" in transpose-config for RISCV.
3, Others are prepared for LoongArch SX and ASX.
Cc: @lixing-star @junchao-loongson