QS8 / QU8 PReLU microkernels

[swamipreksha]

• Implementations for various ISAs:
  • x86 AVX2
  • Scalar ISA
• Unit tests

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[dsharlet]

Thanks for the PR. Unfortunately, it looks like this is implementing the old prelu kernels. We now support prelu as a binary operator, and removed the old prelu operator: #6962, #7034

Can you please add binary operator implementation of the kernels you would like to have instead?

[dsharlet]

Thank you for the PR, this is great work.

Just a few remaining minor nits.

[swamipreksha]

@dsharlet please let us know if any other change is required for approval of the PR.

[dsharlet]

I still think this is a good change, but it is failing tests, can you take a look?

[swamipreksha]

I still think this is a good change, but it is failing tests, can you take a look?

Thank you for the feedback. I'm looking into the test failures and working on a fix.

[swamipreksha]

@dsharlet We have tried fixing the failing testcases. Kindly review.

[swamipreksha]

@dsharlet can we re-run the jobs since most of the jobs got cancelled as they exceeded the maximum execution time while awaiting a runner for 24h0m0s.

[swamipreksha]

@dsharlet Kindly review and approve for merge.

[swamipreksha]

@dsharlet Kindly review and approve for merge.

[dsharlet]

The change I requested looks good. However, there is now a merge conflict with CMakeLists.txt (sorry about that). The tests part of CMakeLists.txt moved to tests/CMakeLists.txt

[swamipreksha]

The change I requested looks good. However, there is now a merge conflict with CMakeLists.txt (sorry about that). The tests part of CMakeLists.txt moved to tests/CMakeLists.txt

Thanks for the update. We have resolved the conflicts and pushed again. Kindly check.

[swamipreksha]

@dsharlet we have resolved the failing check with the latest push. Could you kindly retrigger the tests?

[dsharlet]

When you push fixes, can you please not force-push? It makes it hard to see what you changed.

[dsharlet]

This is failing some tests due to:

src/qu8-vprelu/gen/qu8-vprelu-scalar-u2.c:56:17: error: unused variable 'output_zero_point' [-Werror,-Wunused-variable]
   56 |   const int32_t output_zero_point = params->scalar.output_zero_point;
      |                 ^~~~~~~~~~~~~~~~~
1 error generated.

[swamipreksha]

This is failing some tests due to:

src/qu8-vprelu/gen/qu8-vprelu-scalar-u2.c:56:17: error: unused variable 'output_zero_point' [-Werror,-Wunused-variable]
   56 |   const int32_t output_zero_point = params->scalar.output_zero_point;
      |                 ^~~~~~~~~~~~~~~~~
1 error generated.

@dsharlet we have added a new commit addressing this issue. Kindly check.

[swamipreksha]

Hi @dsharlet, for this PR, copybara-service pushed a commit last week with commit id: e33d847 as mentioned above which passed all the testcases (#8267) but it is now showing as closed with unmerged commits. The failures that we see in this PR were observed much before the copybara-service pushed that commit. Please let us know how to proceed further to get this PR merged.