Fix issues when using MSVC #7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
-- 17f6dab by Dillon <[email protected]>: Add .vs to .gitignore -- 951240c by Dillon <[email protected]>: Fix warnings on MSVC -- 585faa1 by Dillon <[email protected]>: Disable warning on MSVC -- 92acc17 by Dillon <[email protected]>: Disable AVX256 when /vlen not supported by MSVC FUTURE_COPYBARA_INTEGRATE_REVIEW=#7840 from google:ds/windows 92acc17 PiperOrigin-RevId: 728495899
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
-- 17f6dab by Dillon <[email protected]>: Add .vs to .gitignore -- 951240c by Dillon <[email protected]>: Fix warnings on MSVC -- 585faa1 by Dillon <[email protected]>: Disable warning on MSVC -- 92acc17 by Dillon <[email protected]>: Disable AVX256 when /vlen not supported by MSVC FUTURE_COPYBARA_INTEGRATE_REVIEW=#7840 from google:ds/windows 92acc17 PiperOrigin-RevId: 728495899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to work natively with MSVC, this PR has some fixes for minor issues I've encountered: