fix: prevent mutation of input event during temporary state delta stripping by creating a shallow copy#1128
Merged
Merged
Conversation
…ipping by creating a shallow copy
baptmont
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
trimTempDeltaStatepermanently mutated caller-provided event pointers in-place when filtering out temporary state deltas (keys prefixed withtemp:).Changes
trimTempDeltaStateacrossinmemory,database, andvertexaisession service implementations to create a shallow copy of the event object when temporary state delta keys are stripped.len(filteredStateDelta) == len(event.Actions.StateDelta)), avoiding unnecessary struct allocation when the state delta is unchanged.Testing Plan
go test -race ./session/...to verify existing session service tests and new immutability test cases pass.inmemory,database, andvertexaisession backends.