fix: update confirmation wrapper to propagate ProcessRequest calls to underlying tools and intercept packing registration#1130
Merged
Conversation
… underlying tools and intercept packing registration
hanorik
force-pushed
the
process_request_shadowing
branch
from
14e0536 to
f8389c3
Compare
wolo-lab
previously approved these changes
Jul 7, 2026
hanorik
force-pushed
the
process_request_shadowing
branch
from
9c2e8d9 to
eea0167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
tool.WithConfirmation(confirmationTool) shadowed customProcessRequestmethods on wrapped tools.Changes
ProcessRequest: UpdatedconfirmationTool.ProcessRequestintool/tool.goto delegateProcessRequestcalls to the underlying tool if it implements the method.req.ToolsduringProcessRequest, the wrapper replaces that entry with itself so confirmation checks still execute on tool runs.TestWithConfirmation_ProcessRequestandTestWithConfirmation_ProcessRequest_Packing) intool/tool_test.goverifying delegation and registration wrapping.Testing
go test -race ./tool/...