fix: propagate thoughtSignature during streaming#268
Merged
ScottMansfield merged 2 commits intogoogle:mainfrom Apr 16, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Thank you for the patch! I will take a look. Meanwhile, the CLA is needed for any contributions, please look at filling it out. It might be a company one for you if this is on behalf of your company. |
ccb621b to
5eb0128
Compare
Contributor
Author
|
@ScottMansfield my org already had one, I amended my commit to use my work email. |
…ming Gemini thinking models only provide `thoughtSignature` on the first `functionCall` part in a streaming turn. When the model issues multiple concurrent function calls, subsequent parts lack the signature. The API requires matching `thoughtSignature` values on all function response parts, causing 400 errors when the ADK sends responses back. Save the first `thoughtSignature` seen on a function call part and inject it into any subsequent function call parts that are missing it.
5eb0128 to
4d359f2
Compare
ScottMansfield
approved these changes
Apr 16, 2026
Member
|
all done, thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Gemini thinking models only provide
thoughtSignatureon the firstfunctionCallpart in a streaming turn. When the model issues multiple concurrent function calls, subsequent parts lack the signature. The API requires matchingthoughtSignaturevalues on all function response parts, causing 400 errors when the ADK sends responses back.Problem:
Gemini thinking models only provide
thoughtSignatureon the firstfunctionCallpart in a streaming turn. When the model issues multiple concurrent function calls, subsequent parts lack the signature. The API requires matchingthoughtSignaturevalues on all function response parts, causing 400 errors when the ADK sends responses back.Solution:
Save the first
thoughtSignatureseen on a function call part and inject it into any subsequent function call parts that are missing it.Testing Plan
We are using this patch (applied at runtime) in ADK in production today.
Unit Tests:
Manual End-to-End (E2E) Tests:
Setup: Create an agent with 2+ simple tools and a prompt that encourages parallel calls:
What to look for:
Key conditions to reproduce:
Checklist