fix: add client url to support custom url options for DB connection.#284
Merged
kalenkevich merged 1 commit intomainfrom Apr 21, 2026
Merged
fix: add client url to support custom url options for DB connection.#284kalenkevich merged 1 commit intomainfrom
kalenkevich merged 1 commit intomainfrom
Conversation
ScottMansfield
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
getConnectionOptionsFromUribreaks Postgres Unix-socket URLs (percent-encoded host and?host=query-param forms) #2832. Or, if no issue exists, describe the change:
Problem:
When using
DatabaseSessionServicewith non-SQLite database connection URIs via the--session_service_uriflag, the existing logic decomposed the connection string and only returned basic connection options (host,port,user,password, anddbName). This stripped out query parameters (such assslmode=require) and broke standard Postgres Unix-domain socket URL formats containing query parameters or percent-encoded paths, making it impossible to connect to instances requiring specific driver parameters or socket-based routing.Solution:
Simplified
getConnectionOptionsFromUrito directly return theclientUrloption for all non-SQLite drivers, bypassing manual URI parsing completely. Passing the full, untouched connection string down to MikroORM ensures that query parameters and Unix-domain socket configurations are handled natively and correctly by the underlying database drivers.Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
clientUrlin the database configuration.Checklist