-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: implement streaming support in to_a2a for issue #4240 #4230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sanjeevamk1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @sanjeevamk1, thank you for creating this PR! To help reviewers understand and evaluate your contribution, could you please fill out the pull request template in the description? Specifically, please provide the following:
This information is crucial for an efficient review process. You can find more details in our contribution guide. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces streaming support for the to_a2a function. The implementation approach is sound, but I've identified a critical issue with a shadowed import that will likely lead to runtime failures. Additionally, there's an opportunity to improve maintainability by addressing significant code duplication in the new request converter. I've also pointed out a minor typo. Please review my comments for details.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
H @sanjeevamk1, Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you address the comment and also fix the formatting errors before we can proceed with the review. You can use autoformat.sh for formatting errors. |
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
For token streaming when adk agent is exposed with to_a2a
Solution:
Added streaming_mode in to_a2a to select streaming while exposing the agent