Skip to content

ADK changes #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 9, 2025
Merged

ADK changes #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 32 additions & 30 deletions src/app/core/services/agent.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,36 +89,38 @@ describe('AgentService', () => {
});
});

describe('listApps', () => {
it('should call list-apps endpoint with correct url', () => {
service.listApps().subscribe();
const req = httpTestingController.expectOne(
API_SERVER_BASE_URL + LIST_APPS_PATH,
);
expect(req.request.method).toEqual(METHOD_GET);
req.flush([]);
});

it('should return list of apps from http get', async () => {
const appsPromise = firstValueFrom(service.listApps());
const req = httpTestingController.expectOne(
API_SERVER_BASE_URL + LIST_APPS_PATH,
);
req.flush(['app1', 'app2']);
const apps = await appsPromise;
expect(apps).toEqual(['app1', 'app2']);
});

it('should return an empty observable if apiServerDomain is not set',
async () => {
service.apiServerDomain = '';
const appsPromise = firstValueFrom(service.listApps());
const req = httpTestingController.expectOne(LIST_APPS_PATH);
req.flush([]);
const apps = await appsPromise;
expect(apps).toEqual([]);
});
});
// BEGIN-EXTERNAL
// describe('listApps', () => {
// it('should call list-apps endpoint with correct url', () => {
// service.listApps().subscribe();
// const req = httpTestingController.expectOne(
// API_SERVER_BASE_URL + LIST_APPS_PATH,
// );
// expect(req.request.method).toEqual(METHOD_GET);
// req.flush([]);
// });

// it('should return list of apps from http get', async () => {
// const appsPromise = firstValueFrom(service.listApps());
// const req = httpTestingController.expectOne(
// API_SERVER_BASE_URL + LIST_APPS_PATH,
// );
// req.flush(['app1', 'app2']);
// const apps = await appsPromise;
// expect(apps).toEqual(['app1', 'app2']);
// });

// it('should return an empty observable if apiServerDomain is not set',
// async () => {
// service.apiServerDomain = '';
// const appsPromise = firstValueFrom(service.listApps());
// const req = httpTestingController.expectOne(LIST_APPS_PATH);
// req.flush([]);
// const apps = await appsPromise;
// expect(apps).toEqual([]);
// });
// });
// END-EXTERNAL

describe('runSse', () => {
it('should set loading state to true when called', () => {
Expand Down