Gather data for fetch metrics (but do not transmit) V2#2391
Open
cjreynol wants to merge 9 commits intogoogle:mainfrom
Open
Gather data for fetch metrics (but do not transmit) V2#2391cjreynol wants to merge 9 commits intogoogle:mainfrom
cjreynol wants to merge 9 commits intogoogle:mainfrom
Conversation
jemoreira
reviewed
Apr 14, 2026
Databean
reviewed
Apr 14, 2026
cjreynol
force-pushed
the
fetch_metrics_plumbing_v2
branch
3 times, most recently
from
6f9bd1b to
a3e334d
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
approved these changes
Apr 17, 2026
cjreynol
force-pushed
the
fetch_metrics_plumbing_v2
branch
from
a3e334d to
9f0aa6a
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
cjreynol
force-pushed
the
fetch_metrics_plumbing_v2
branch
from
9f0aa6a to
32332d1
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
cjreynol
force-pushed
the
fetch_metrics_plumbing_v2
branch
from
32332d1 to
908096a
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
cjreynol
added
kokoro:run
GoogleCuttlefishTesterBot
removed
kokoro:run
cjreynol
force-pushed
the
fetch_metrics_plumbing_v2
branch
from
7e26614 to
0b07356
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
When fetch metrics are added, the `DeviceEventType` enum will not be the only set of possible values used for creating the filenames. Bug: 491965176
Move that to a `DeviceMetricsInput` and have it own the base data (which is only one field, but will expand as the base metrics gathering expands). This will be mirrored with a `FetchMetricsInput` in an upcoming commit, so that each `*Input` class has only the data it contains and the shared `metrics_orchestration.h/cc` logic does not need to know about the divergent implementations. Bug: 491965176
To also be used by fetch metrics gathering. Bug: 491965176
To be used in `MetricsData` to hold for conversion. Bug: 491965176
To be used in `CvdFetchCommandHandler`. Bug: 491965176
Note, this is only completing the data gathering steps, not transmission. The new fetch fields do not yet exist in the proto and are not being populated in `metrics_conversion.cc`. Bug: 491965176
cjreynol
force-pushed
the
fetch_metrics_plumbing_v2
branch
from
0b07356 to
9b49ead
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
To help with debugging. Bug: 506233124
For debugging errors in the metrics tests. Particularly to make the V2 `metrics.log` available for review. Bug: 506233124
Specifically for device metrics generation. Now that fetch operations can generate metrics events, by the time `cvd create` is run a session_id file may already exist. In particular, this was occuring in Kokoro test runs, where the fetch target directory and the `cvd create` home directory were identical. That caused the `metrics` directory created to hold these V2 metrics files to be the same, and `cvd create` events (device instantiation) were failing trying to create a `metrics_session_id.txt` file when one already existed. Bug: 491965176
cjreynol
force-pushed
the
fetch_metrics_plumbing_v2
branch
from
9b49ead to
3c2df9a
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Updated version of #2290 after #2387)
Gather the data for fetch metrics and make it available in metrics_conversion.cc, ready to be added to the transmitted proto AFTER the new fields are approved.
Also, includes some changes to the existing device metrics gathering to account for a the new fetch metrics logic paths.
Bug: 491965176