Add OnFrameDropped override to LocalRecorder::Display#2448
Open
sprangerik wants to merge 1 commit intogoogle:mainfrom
Open
Add OnFrameDropped override to LocalRecorder::Display#2448sprangerik wants to merge 1 commit intogoogle:mainfrom
sprangerik wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sprangerik
force-pushed
the
on_frame_dropped
branch
from
ed446e4 to
cfb0848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a virtual
OnFrameDroppedmethod tocuttlefish::webrtc_streaming::LocalRecorder::Displaysince that implements thewebrtc::EncodedImageCallbackinterface.The deps in this project currently points to a quite old commit from early December 2025 and doesn't yet have the new method, but after an update it's likely to be breaking since the new method will be made pure virtual soon.
See https://groups.google.com/g/discuss-webrtc/c/Cf9aJcWKns8 for more details.
To avoid breakages, this PR adds the new virtual method but does not yet mark it as override.