Pass through the path to the iptables binary.#2460
Open
3405691582 wants to merge 1 commit intogoogle:mainfrom
Open
Pass through the path to the iptables binary.#24603405691582 wants to merge 1 commit intogoogle:mainfrom
3405691582 wants to merge 1 commit intogoogle:mainfrom
Conversation
Earlier in google#2405 we added some functionality such that we could resolve names against PATH manually. We need to do this for the iptables command specifically, since some environments do not have iptables in PATH unless invoked with sudo, and it is the one utility that both the netlink driver and the iproute2 drivers still shell out to the system for. Ahead of us using the new utilities to resolve the iptables binary, let us manually specify the path for now. While there is no guarantee that we'll find iptables there outside of Linux, both these drivers are all Linux specific anyway, and if iptables isn't found here, this still wouldn't work, so we aren't regressing in terms of portability or functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier in #2405 we added some functionality such that we could resolve names against PATH manually. We need to do this for the iptables command specifically, since some environments do not have iptables in PATH unless invoked with sudo, and it is the one utility that both the netlink driver and the iproute2 drivers still shell out to the system for.
Ahead of us using the new utilities to resolve the iptables binary, let us manually specify the path for now. While there is no guarantee that we'll find iptables there outside of Linux, both these drivers are all Linux specific anyway, and if iptables isn't found here, this still wouldn't work, so we aren't regressing in terms of portability or functionality.