Join filter queries using Intersect and Union #2742
Conversation
engine/src/main/java/com/google/android/fhir/search/MoreSearch.kt
Outdated
Show resolved
Hide resolved
| SELECT a.resourceUuid, a.serializedResource | ||
| FROM ResourceEntity a | ||
| WHERE a.resourceUuid IN ( | ||
| SELECT resourceUuid FROM StringIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND index_value = ? | ||
| UNION | ||
| SELECT resourceUuid FROM StringIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND index_value = ? | ||
| INTERSECT | ||
| SELECT resourceUuid | ||
| FROM ResourceEntity a | ||
| WHERE a.resourceType = ? AND a.resourceId IN ( | ||
| SELECT substr(a.index_value, 9) | ||
| FROM ReferenceIndexEntity a | ||
| WHERE a.index_name = ? AND a.resourceUuid IN ( | ||
| SELECT resourceUuid FROM TokenIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND (index_value = ? AND IFNULL(index_system,'') = ?) | ||
| UNION | ||
| SELECT resourceUuid FROM TokenIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND (index_value = ? AND IFNULL(index_system,'') = ?) | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I think this won't perform as expected. The precedence of INTERSECTION is higher than UNION. Therefore, this query is interpreted as:
(Given: "John") UNION ( (Given: "Jane") INTERSECT (Condition: Diabetes OR Hypertension) )
This is not the intended logic. The test is trying to find Patients where:
( (Given: "John" OR Given: "Jane") AND (Condition: Diabetes OR Condition: Hypertens
There was a problem hiding this comment.
Can you confirm this? And make changes if needed ?
There was a problem hiding this comment.
Cool, will have a look
There was a problem hiding this comment.
No, not yet...I had started but didn't finish. Let me set up some time next week to get it done
There was a problem hiding this comment.
Tested these query statements
SELECT * FROM (VALUES (1), (2), (3))
UNION
SELECT * FROM (VALUES (3), (4), (5))
UNION
SELECT * FROM (VALUES (5), (6), (7))
INTERSECT
SELECT * FROM (VALUES (6), (3), (8));returned rows 3, 6
SELECT * FROM (VALUES (1), (2), (3))
INTERSECT
SELECT * FROM (VALUES (9), (4), (5))
UNION
SELECT * FROM (VALUES (5), (6), (7))
UNION
SELECT * FROM (VALUES (6), (3), (8));returned rows 3, 5, 6, 7, 8
With these it wasn't quite clear that the INTERSECT has a higher precedence than UNION but rather evaluated sequentially with no actual precedence over the other.
All the same, I've updated the query to group the SELECT statements used in the Intersect with nested query
3 participants
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2725
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.