Skip to content

Fix #976: Document timing function constants in sync #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #976: Document timing function constants in sync #2396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/dc_figma_import/src/reaction_schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ pub enum EasingJson {

// We flatten the Easing type to a bezier for the toolkit. These values were taken from
// https://easings.net/ and verified against Figma optically.
Comment thread
This conversation was marked as resolved.
//
// These cubic bezier control points are from an old reference (Robert Penner named these
// values, Macromedia Flash developers popularized them, and now they're in Figma, unchanged).
// We've verified optically that they produce the same output as Figma's preview viewer.
//
// For the spring values, they were taken from Figma's blog post announcing the
// spring timing function.
impl Into<Easing_type> for EasingJson {
fn into(self) -> Easing_type {
match self {
Expand Down
Loading