Skip to content

Detect ida.exe vs ida64.exe at runtime to support IDA 9.0+ #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmoski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Detect ida.exe vs ida64.exe at runtime to support IDA 9.0+ #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions util/idb_export.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,24 @@ absl::Status ExportDatabase(const std::string& idb_path,
return absl::NotFoundError(absl::StrCat("File not found: " + idb_path));
}

#if IDA_SDK_VERSION < 900
// Pick the right IDA executable at runtime. IDA 9.0+ removed the separate
// ida64 binary and unified everything into ida(.exe); older releases ship
// both. Detect which is present in `options.ida_dir` so the same binary
// works against either layout. The compile-time IDA_SDK_VERSION switch
// previously used here was unreliable: binexport_shared is built without
// -DIDA_SDK_VERSION=…, so the macro defaulted to 0 and `ida64` was always
// selected — breaking IDA 9.x exports from the bindiff CLI.
const bool is_64bit = absl::EndsWithIgnoreCase(idb_path, kIdbExtension64);
#ifdef _WIN32
const std::string ida_exe = is_64bit ? "ida64.exe" : "ida.exe";
#else
const std::string ida_exe = is_64bit ? "ida64" : "ida";
#endif
#ifdef _WIN32
std::string ida_exe = "ida.exe";
if (is_64bit && FileExists(JoinPath(options.ida_dir, "ida64.exe"))) {
ida_exe = "ida64.exe";
}
#else
#ifdef _WIN32
const std::string ida_exe = "ida.exe";
#else
const std::string ida_exe = "ida";
#endif
std::string ida_exe = "ida";
if (is_64bit && FileExists(JoinPath(options.ida_dir, "ida64"))) {
ida_exe = "ida64";
}
#endif
std::vector<std::string> args;
args.push_back(JoinPath(options.ida_dir, ida_exe));
Expand Down