add args types #693
Closed
add args types #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
previously approved these changes
May 14, 2025
bumble/a2dp.py
Outdated
| @@ -144,7 +144,7 @@ | |||
|
|
|||
|
|
|||
| # ----------------------------------------------------------------------------- | |||
| def flags_to_list(flags: bool, values: list) -> list: | |||
| def flags_to_list(flags: bool, values: list[int]) -> list[int]: | |||
There was a problem hiding this comment.
Could be removed because it's not used anywhere.
zxzxwu
reviewed
May 14, 2025
| @@ -181,7 +181,9 @@ def __init__( | |||
|
|
|||
| if reset_energy_expended: | |||
|
|
|||
| def write_heart_rate_control_point_value(connection, value): | |||
| def write_heart_rate_control_point_value( | |||
| connection: int, value: int | |||
barbibulle
reviewed
May 17, 2025
| @@ -181,7 +181,9 @@ def __init__( | |||
|
|
|||
| if reset_energy_expended: | |||
|
|
|||
| def write_heart_rate_control_point_value(connection, value): | |||
| def write_heart_rate_control_point_value( | |||
| connection: int, value: int | |||
There was a problem hiding this comment.
connection: Connection
| @@ -87,7 +87,7 @@ def __init__( | |||
| self.rr_intervals = rr_intervals | |||
|
|
|||
| @classmethod | |||
| def from_bytes(cls, data): | |||
| def from_bytes(cls, data: bytes): | |||
There was a problem hiding this comment.
return type: HeartRateMeasurement
| @@ -63,7 +63,7 @@ class BodySensorLocation(IntEnum): | |||
| class HeartRateMeasurement: | |||
| def __init__( | |||
| self, | |||
| heart_rate, | |||
| heart_rate: int, | |||
There was a problem hiding this comment.
since we're adding types, the other parameters and return value should be typed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.