Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the fix, @ViktorDomazetoski! Once you sign the CLA mentioned above and address the formatting issues identified by our automatic checks (i.e. https://github.com/google/cameratrapai/actions/runs/17946293131/job/51082087160?pr=45), we're happy to approve your change. If you're feeling even more adventurous, since you uncovered a bug for which we didn't test properly, feel free to add a test in |
stefanistrate
left a comment
There was a problem hiding this comment.
Thank you for your contribution, @ViktorDomazetoski! Looking great.
When using a batch size above 1, the returned target logits for the entire batch are equal to the first element of the batch. The fix enumerates through the predictions to get the logit for the corresponding element of the batch.