This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Camera2: Fail gracefully if an exception occurs within a callback #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should prevent hard crashes when we can't load cameraview.
Before: app crashes if these exception occur
This occurred while I was testing out cameraview and then created an intent to load the camera. When the intent came back and
onResume()was called (which then calledcameraview.start()the sample app would hard crash.This prevents a hard crash but still leaves the cameraview in a broken state.
Was tested using https://github.com/lytefast/flex-input +
Google PixelPhone:0) disable the google pixel from the blacklist in CameraFragment#isBlacklistedDevice()
(+)buttonResult: app hard crashes
With change: picture is captured, cameraview is broken, but the app is still running correctly.