Fix -Wsign-compare and -Wundef warnings from clang on Windows #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These warning were initially reported by Chromium, and I've managed to fix the Abseil testing configuration to find these warnings. Currently CCTZ doesn't test clang on Windows.
dinord
approved these changes
Nov 25, 2025
devbww
reviewed
Nov 26, 2025
| #include <string> | ||
| #include <vector> | ||
| #if !HAS_STRPTIME | ||
| #if !defined(HAS_STRPTIME) |
Contributor
There was a problem hiding this comment.
#if !defined(HAS_STRPTIME) is not the same as #if !HAS_STRPTIME when HAS_STRPTIME=0, which is intended to be a valid way to say "I don't have strptime()".
I see that we have #if defined(HAS_STRPTIME) && HAS_STRPTIME in another place (presumably to workaround the same warning), so I suggest we rework these new changes with the negation of that.
[All that said, I'm not a fan of -Wundef, but I guess that's a lost argument.]
derekmauro
added a commit
to derekmauro/cctz
that referenced
this pull request
Nov 26, 2025
Builds now always have a default value of 0 or 1 for HAS_STRPTIME, but it can be overridden on the commandline. This is to address -Wundef warnings, and the feedback from google#330.
derekmauro
added a commit
that referenced
this pull request
Dec 1, 2025
Builds now always have a default value of 0 or 1 for HAS_STRPTIME, but it can be overridden on the command-line. This is to address -Wundef warnings, and the feedback from #330.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These warning were initially reported by Chromium, and I've managed to fix the Abseil testing configuration to find these warnings.
Currently CCTZ doesn't test clang on Windows.