Add py_proto_library targets #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the protos in Python.
Note, in reference to two old, alternative PRs (PR1, PR2): To the best of my knowledge, there are (or there used to be) three implementations of
py_proto_libraryto choose from, and they don't mix well. The Protobuf team has taken ownership ofpy_proto_libraryand the implementation from the Protobuf repository is the one to use now.py_proto_libraryfromrules_pythonhas been removed in favor of the one from Protobuf.py_proto_libraryfrom gRPC is also deprecated. gRPC is migrating to the one from Protobuf.