Skip to content

feat: readability improvements to OSV record #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsutedjo merged 2 commits into from
Mar 20, 2025
Merged

feat: readability improvements to OSV record #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6bf8e0
feat: readability improvements to OSV record
andrewpollock Mar 20, 2025
8bad78f
fix: reinstate PolicyLink struct field
andrewpollock Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion policies/V8-policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@
],
"freshness_days": 7,
"policy_link": "https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/security/updates.md",
"description": "Dependency on outdated V8 found. Please update to the latest [beta](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/beta), [stable](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/stable), or [extended stable](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/extended) versions."
"summary": "Outdated dependency on V8 found (see details)",
"description": "Outdated dependency on V8 found (see [policy](https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/security/updates.md).\n\nPlease update to the latest [beta](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/beta), [stable](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/stable), or [extended stable](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/extended) versions."
Copy link

@oliverchang oliverchang Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is missing a ) after the "policy" here.

noticed this on http://test.osv.dev/V8-FRESHNESS

Copy link
Contributor Author

@andrewpollock andrewpollock Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

}
3 changes: 2 additions & 1 deletion src/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type Policy struct {
Repository string `json:"repository"`
FreshnessDays int `json:"freshness_days"`
PolicyLink string `json:"policy_link"`
Summary string `json:summary`
Description string `json:"description"`
Branches []string `json:"branches"`
}
Expand Down Expand Up @@ -222,7 +223,7 @@ func updateAdvisory(advisory *Advisory, policy *Policy, cache map[string][]strin

advisory.ID = policy.ID
advisory.Modified = nowTimestamp
advisory.Summary = policy.PolicyLink
advisory.Summary = policy.Summary
advisory.Details = policy.Description
advisory.Affected = []AffectedItem{*affectedItem}

Expand Down
4 changes: 2 additions & 2 deletions src/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func TestUpdateAdvisory(t *testing.T) {
ID: "policyID",
Repository: "owner/repo",
FreshnessDays: 1,
PolicyLink: "policyLink",
Summary: "policySummary",
Description: "policyDescription",
}

Expand All @@ -261,7 +261,7 @@ func TestUpdateAdvisory(t *testing.T) {
ID: "policyID",
Modified: nowTimestamp,
Published: nowTimestamp,
Summary: "policyLink",
Summary: "policySummary",
Details: "policyDescription",
Affected: []AffectedItem{
{
Expand Down