Skip to content

Stop hiding errors when parsing testcase_ids #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/clusterfuzz/_internal/datastore/data_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,11 @@ def get_domain():
return local_config.GAEConfig().get('domains.main', default=default_domain)


def get_testcase_by_id(testcase_id):
def get_testcase_by_id(testcase_id: str) -> data_types.Testcase:
"""Return the testcase with the given id.
Raises InvalidTestcaseError if no such testcase exists.
"""
try:
parsed_id = int(testcase_id)
except ValueError:
raise errors.InvalidTestcaseError(testcase_id)

parsed_id = int(testcase_id)
if parsed_id == 0:
raise errors.InvalidTestcaseError(0)

Expand Down
Loading