-
Notifications
You must be signed in to change notification settings - Fork 274
Vendor bazel's starlark package #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keith
wants to merge
7
commits into
google:master
Choose a base branch
from
keith:ks/vendor-starlark
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
57ba7ec
Copy direct bazel starlark packages
keith aba8531
Copy bazel/third_party/BUILD
keith 0aebc7d
Remove unused targets, fix maven labels
keith 5136f01
Update labels and visibility
keith 1609c27
Remove more unused third parties from bazel
keith 576f0cb
Remove maven repo for bazel itself
keith 1934263
Remove io_bazel repository
keith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Bazel's Starlark interpreter | ||
|
|
||
| licenses(["notice"]) | ||
|
|
||
| filegroup( | ||
| name = "srcs", | ||
| srcs = ["BUILD"], | ||
| visibility = [":bazel"], | ||
| ) | ||
|
|
||
| # The java.starlark.net project, including its tests. | ||
| package_group( | ||
| name = "starlark", | ||
| packages = [ | ||
| "//src/test/java/net/starlark/java/...", | ||
| "//third_party/bazel/main/java/net/starlark/java/...", | ||
| ], | ||
| ) | ||
|
|
||
| # Bazel and its tests. | ||
| package_group( | ||
| name = "bazel", | ||
| packages = ["//src/..."], | ||
| ) | ||
|
|
||
| # The Java Starlark interpreter is not supported for general use as a public | ||
| # API. However, Copybara and Stardoc are approved clients. | ||
| # | ||
| # We do not use visibility to prevent other dependencies, because cross-repo | ||
| # visibility restrictions do not make sense. Just be aware this is not | ||
| # guaranteed as a stable API. | ||
| package_group( | ||
| name = "clients", | ||
| packages = ["public"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| load("@rules_java//java:defs.bzl", "java_library") | ||
|
|
||
| package( | ||
| default_applicable_licenses = ["//third_party/bazel:license"], | ||
| default_visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| filegroup( | ||
| name = "srcs", | ||
| srcs = glob(["**"]), | ||
| visibility = ["//src:__subpackages__"], | ||
| ) | ||
|
|
||
| # Annotations to make Java classes and methods accessible from Starlark. | ||
| # Depending on this library adds annotations processing to the build. | ||
| java_library( | ||
| name = "annot", | ||
| exported_plugins = ["//third_party/bazel/main/java/net/starlark/java/annot/processor"], | ||
| visibility = ["//third_party/bazel/main/java/net/starlark/java:clients"], | ||
| exports = [":annot_sans_processor"], | ||
| ) | ||
|
|
||
| # Annotations without processor, to avoid a dependency cycle in the processor itself. | ||
| java_library( | ||
| name = "annot_sans_processor", | ||
| srcs = glob(["*.java"]), | ||
| visibility = ["//third_party/bazel/main/java/net/starlark/java/annot/processor:__pkg__"], | ||
| deps = [ | ||
| "//third_party/bazel/third_party:guava", | ||
| "//third_party/bazel/third_party:jsr305", | ||
| ], | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps rules_python dependency can be dropped as well? It seems it's only needed by io_bazel and not referenced in this repo