Recognize Iterator trait via DefId, not def path.#1039
Open
copybara-service[bot] wants to merge 1 commit into
Open
Recognize Iterator trait via DefId, not def path.#1039copybara-service[bot] wants to merge 1 commit into
Iterator trait via DefId, not def path.#1039copybara-service[bot] wants to merge 1 commit into
Conversation
In Chromium `tcx.def_path_str` may return `core::iter::Iterator` and fail the old checks. The `DefId`-based checks should be more robust. PiperOrigin-RevId: 916314962
copybara-service
Bot
force-pushed
the
test_916314962
branch
from
569a98e to
1f89f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize
Iteratortrait viaDefId, not def path.In Chromium
tcx.def_path_strmay returncore::iter::Iteratorand fail the old checks. The
DefId-based checks should bemore robust.