Prepare AdtCoreBindings for supporting opaque types#1478
Open
copybara-service[bot] wants to merge 1 commit into
Open
Prepare AdtCoreBindings for supporting opaque types#1478copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
cc_bindings_from_rs operates really nicely on the `AdtCoreBindings` type, since it fits into a lot of abstractions like generating trait methods and impls easily. Since I want to reuse most of this machinery for opaque types like `-> impl Drop` (and eventually `-> impl Future`), this CL sets up `AdtCoreBindings` to be reusable by abstracting the parts that opaque types can share from the parts that they can't, like `rs_fully_qualified_name`. While this change by itself doesn't look impactful and could be folded into followup CLs, splitting it out massively reduces noise :) PiperOrigin-RevId: 951473412
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare AdtCoreBindings for supporting opaque types
cc_bindings_from_rs operates really nicely on the
AdtCoreBindingstype, since it fits into a lot of abstractions like generating trait methods and impls easily. Since I want to reuse most of this machinery for opaque types like-> impl Drop(and eventually-> impl Future), this CL sets upAdtCoreBindingsto be reusable by abstracting the parts that opaque types can share from the parts that they can't, likers_fully_qualified_name. While this change by itself doesn't look impactful and could be folded into followup CLs, splitting it out massively reduces noise :)