rs_bindings_from_cc: move #[provided] functions into a regular impl.#683
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
rs_bindings_from_cc: move #[provided] functions into a regular impl.#683copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
Now that there's just one database type, the #[provided] functions don't need to live inside of the macro. It would be more IDE-friendly and easier to understand if they were instead in an impl outside of the block. PiperOrigin-RevId: 883393457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rs_bindings_from_cc: move #[provided] functions into a regular impl.
Now that there's just one database type, the #[provided] functions don't need to live
inside of the macro. It would be more IDE-friendly and easier to understand if they
were instead in an impl outside of the block.