Add support for custom DropImpl in CRUBIT_OWNED_POINTEE and refactor IR.#860
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Add support for custom DropImpl in CRUBIT_OWNED_POINTEE and refactor IR.#860copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_894250803
branch
5 times, most recently
from
9b11ce1 to
980df82
Compare
- Support an optional second argument in CRUBIT_OWNED_POINTEE to specify a custom DropImpl method name. - Refactor Crubit IR to group owned_ptr_type and drop_impl into a single OwnedPtrConfig struct. - Apply default value of "DropImpl" at annotation parsing time. - Add GetAnnotationWithStringArgs helper in common/annotation_reader.h and use it in cxx_record.cc. PiperOrigin-RevId: 894250803
copybara-service
Bot
force-pushed
the
test_894250803
branch
from
980df82 to
3af1944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for custom DropImpl in CRUBIT_OWNED_POINTEE and refactor IR.
a custom DropImpl method name.
OwnedPtrConfig struct.
and use it in cxx_record.cc.