Remove C++23 use of std::unexpected from result.h.#895
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Remove C++23 use of std::unexpected from result.h.#895copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_905229720
branch
from
89065dc to
173c5d0
Compare
In practice, this turns out to not work how we want because `std::unexpected` imposes more constraints on it's template parameter than we do (it can't be a forward declared type). It'd be nice if we could reuse types, but given it's a compilation error remove them in favor of always using our own types. PiperOrigin-RevId: 905229720
copybara-service
Bot
force-pushed
the
test_905229720
branch
from
173c5d0 to
2454243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove C++23 use of std::unexpected from result.h.
In practice, this turns out to not work how we want because
std::unexpectedimposes more constraints on it's template parameterthan we do (it can't be a forward declared type). It'd be nice if we
could reuse types, but given it's a compilation error remove them in
favor of always using our own types.