layouts: use 'note' role instead of 'alert'#2553
Open
orangecms wants to merge 1 commit intogoogle:mainfrom
Open
layouts: use 'note' role instead of 'alert'#2553orangecms wants to merge 1 commit intogoogle:mainfrom
orangecms wants to merge 1 commit intogoogle:mainfrom
Conversation
The 'alert' role is meant for feedback deserving immediate attention, such as an incoming message. The 'note' role, on the other hand, is meant for content that has no suitable semantic element otherwise and is supposed to hint the user on ancillary information. See: - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/alert_role - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/note_role Signed-off-by: Daniel Maslowski <info@orangecms.org>
Collaborator
Hi @orangecms 👋🏻 Thanks for point this out! Let me create an issue to track this. I feel that we need a more nuanced solution that what is proposed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'alert' role is meant for feedback deserving immediate attention, such as an incoming message.
The 'note' role, on the other hand, is meant for content that has no suitable semantic element otherwise and is supposed to hint the user on ancillary information.
See:
same as kubernetes/website#54363