Skip to content

Add Romanian locale#2583

Open
didiViking wants to merge 4 commits intogoogle:mainfrom
didiViking:romanian-locale
Open

Add Romanian locale#2583
didiViking wants to merge 4 commits intogoogle:mainfrom
didiViking:romanian-locale

Conversation

@didiViking
Copy link

@google-cla
Copy link

google-cla bot commented Feb 24, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@didiViking
Copy link
Author

@chalin Hi, I'm not sure who needs to approve this workflow. Thank you!

@didiViking
Copy link
Author

@svrnm If you could please approve this, thank you.

@svrnm
Copy link
Contributor

svrnm commented Feb 25, 2026

@didiViking best you ask some other Romanian speakers to approve and verify (even if they only provide a LGTM here as a comment), I think that's the most helpful to the docsy maintainers

@didiViking
Copy link
Author

@dnanuti @IrinaKarantoniou @miaits If I could have your review on the Romanian content, many thanks.

@didiViking
Copy link
Author

@IrinaKarantoniou Thank you for the review, all has been corrected. Please re-check and leave a LGTM if all is ok.

@IrinaKarantoniou
Copy link

@didiViking You are very welcome! ❤️ LGTM

@didiViking
Copy link
Author

@svrnm Good to merge. Thank you.

@svrnm
Copy link
Contributor

svrnm commented Feb 26, 2026

@svrnm Good to merge. Thank you.

I am not the person that is able to help you with that, the docsy maintainers will have to take a look.

@didiViking
Copy link
Author

@chalin Hi, it seems that you were able to merge your PRs. Could you please approve this one or LMK how I can merge it? Thank you.

@chalin chalin force-pushed the romanian-locale branch from e82edea to 2d638d2 Compare March 1, 2026 00:10
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @didiViking @IrinaKarantoniou - thank you for this contribution. I'll review it as soon as I can when I'm back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants