Fix un-expansion of macros when the spacing around its use is changed by translation #1027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParameterAwareMacroExpanderwould capture spaces before macro names - storing it in the string that it uses to later un-expand macros. This would break in cases where the translation tool produced names with more qualifiers than the corresponding input.Before:
create [$table]create actual_tablecreate db.actual_tablecreate db.actual_tableAfter:
create [$table]create actual_tablecreate db.actual_tablecreate db.[$table](
ParameterAwareMacroExpandershould not have modified its input pattern without documenting that it does so)