Initial commit for gcsync command line tool #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyxiaowei
requested review from
vladislav-sidorovich and
shevek-google
as code owners
misolt
reviewed
Mar 18, 2025
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/Constants.java
Show resolved
Hide resolved
misolt
reviewed
Mar 18, 2025
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/Constants.java
Show resolved
Hide resolved
misolt
reviewed
Mar 18, 2025
dbsync/gcsync/src/test/java/com/google/edwmigration/dbsync/gcsync/GcsyncClientTest.java
Show resolved
Hide resolved
misolt
reviewed
Mar 18, 2025
dbsync/common/src/main/java/com/google/edwmigration/dbsync/common/InstructionReceiver.java
Outdated
Show resolved
Hide resolved
misolt
reviewed
Mar 18, 2025
dbsync/common/src/main/java/com/google/edwmigration/dbsync/common/InstructionReceiver.java
Outdated
Show resolved
Hide resolved
shevek-google
requested changes
Mar 18, 2025
dbsync/common/src/main/java/com/google/edwmigration/dbsync/common/InstructionGenerator.java
Outdated
Show resolved
Hide resolved
dbsync/common/src/main/java/com/google/edwmigration/dbsync/common/InstructionReceiver.java
Outdated
Show resolved
Hide resolved
dbsync/common/src/main/java/com/google/edwmigration/dbsync/common/InstructionReceiver.java
Outdated
Show resolved
Hide resolved
dbsync/common/src/main/java/com/google/edwmigration/dbsync/common/InstructionReceiver.java
Outdated
Show resolved
Hide resolved
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/GcsyncClient.java
Show resolved
Hide resolved
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/GcsyncClient.java
Show resolved
Hide resolved
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/GcsyncClient.java
Outdated
Show resolved
Hide resolved
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/GenerateCheckSumMain.java
Outdated
Show resolved
Hide resolved
shevek-google
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
One small nit.
From a high level, this PR appears to improve some things, and regress nothing. Plato would approve of it, and therefore, so do I.
Please satisfy yourself that you have at least one other reviewer who has gone deeper into the implementation details than I have, then resolve "done" comments and commit.
dbsync/common/src/main/java/com/google/edwmigration/dbsync/common/InstructionReceiver.java
Outdated
Show resolved
Hide resolved
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/GcsyncClient.java
Show resolved
Hide resolved
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/Constants.java
Outdated
Show resolved
Hide resolved
dbsync/gcsync/src/main/java/com/google/edwmigration/dbsync/gcsync/GcsyncMain.java
Outdated
Show resolved
Hide resolved
ikhavkin-google
approved these changes
Mar 25, 2025
vladislav-sidorovich
approved these changes
Mar 25, 2025
|
s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of gcsync command
Fix of an issue in the core rsync algorithm
Replace the use of slice()
#. Use full 256 bits checksum
Unit test for gcsyncClient