[Snowflake Connector] Add tests for connector's SQL overrides. #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolomorandini
requested review from
shevek-google and
vladislav-sidorovich
as code owners
paolomorandini
requested review from
Hackerpilot,
kpiotrowski,
misolt,
shevek-google and
vladislav-sidorovich
and removed request for
shevek-google and
vladislav-sidorovich
...com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeTaskUtil.java
Outdated
Show resolved
Hide resolved
misolt
reviewed
Mar 31, 2025
...com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeTaskUtil.java
Outdated
Show resolved
Hide resolved
paolomorandini
force-pushed
the
snowflake-test-overrides
branch
from
38879e8 to
3ed8870
Compare
misolt
reviewed
Apr 1, 2025
...wmigration/dumper/application/dumper/connector/snowflake/SnowflakeMetadataConnectorTest.java
Outdated
Show resolved
Hide resolved
misolt
reviewed
Apr 1, 2025
...wmigration/dumper/application/dumper/connector/snowflake/SnowflakeMetadataConnectorTest.java
Outdated
Show resolved
Hide resolved
misolt
reviewed
Apr 1, 2025
dumper/app/src/test/resources/connector/snowflake/assessment-jdbc-tasks-sql-override-query.yaml
Outdated
Show resolved
Hide resolved
vladislav-sidorovich
approved these changes
Apr 1, 2025
misolt
reviewed
Apr 1, 2025
...e/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeMetadataConnector.java
Outdated
Show resolved
Hide resolved
paolomorandini
force-pushed
the
snowflake-test-overrides
branch
5 times, most recently
from
d4193c6 to
513db1e
Compare
misolt
approved these changes
Apr 2, 2025
misolt
reviewed
Apr 2, 2025
...wmigration/dumper/application/dumper/connector/snowflake/SnowflakeMetadataConnectorTest.java
Outdated
Show resolved
Hide resolved
paolomorandini
force-pushed
the
snowflake-test-overrides
branch
from
513db1e to
c475329
Compare
paolomorandini
force-pushed
the
snowflake-test-overrides
branch
from
c475329 to
69bc38b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.